Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Fix bug with from_argparse and finetune #382

Merged
merged 3 commits into from
Jun 8, 2021
Merged

Fix bug with from_argparse and finetune #382

merged 3 commits into from
Jun 8, 2021

Conversation

ethanwharris
Copy link
Collaborator

What does this PR do?

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jun 8, 2021 •
edited
Loading

Codecov Report

Merging #382 (330ebe0) into master (5a4d94b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #382   +/-   ##
=======================================
  Coverage   89.45%   89.45%           
=======================================
  Files          80       80           
  Lines        4192     4192           
=======================================
  Hits         3750     3750           
  Misses        442      442
Flag Coverage Δ
unittests 89.45% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/__about__.py 100.00% <100.00%> (ø)
flash/core/trainer.py 87.50% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a4d94b...330ebe0. Read the comment docs.

@ethanwharris ethanwharris merged commit 7d4330b into master Jun 8, 2021
@ethanwharris ethanwharris deleted the bugfix/from_argparse_args_cls branch June 8, 2021 14:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@edgarriba edgarriba edgarriba approved these changes

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@carmocca carmocca Awaiting requested review from carmocca

@justusschock justusschock Awaiting requested review from justusschock

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@tchaton tchaton Awaiting requested review from tchaton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ethanwharris @edgarriba